gremling/KytyPS5
1
0 Fork 0
mirror of https://github.com/KytyPS5/KytyPS5.git synced 2026-10-27 16:02:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

renderer: execute attachmentless PS side-effect draws

Browse Source
This commit is contained in:
nmzik committed 2026-08-18 14:03:36 +02:00
1 parent e39162fc52
commit 8cfc9cd7a8
2 files changed
+17 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/graphics/host_gpu/renderer/pipeline/pipelineCache.cpp
+6
View File
@@ -121,6 +121,12 @@ PipelineCache::GraphicsPipeline& PipelineCache::CreateGraphicsPipeline(
depth.samples); depth.samples);
} }
} }
if (color_count == 0 && !with_depth) {
attachment_samples = render_sample_count(ctx.GetAaConfig().msaa_num_samples);
EXIT_IF(!static_cast<bool>(
m_graphics.GetPhysicalDeviceProperties().limits.framebufferNoAttachmentsSampleCounts &
vulkan_sample_count(attachment_samples)));
}
EXIT_IF(attachment_samples == 0 || EXIT_IF(attachment_samples == 0 ||
vulkan_sample_count(attachment_samples) == vk::SampleCountFlagBits {}); vulkan_sample_count(attachment_samples) == vk::SampleCountFlagBits {});
src/graphics/host_gpu/renderer/renderDraw.cpp
+11 -4
View File
@@ -340,6 +340,9 @@ static PipelineDynamicParameters BuildGraphicsDynamicParams(const RenderCommandB
framebuffer_extent = colors[0].extent; framebuffer_extent = colors[0].extent;
} else if (depth.image_id) { } else if (depth.image_id) {
framebuffer_extent = {depth.width, depth.height}; framebuffer_extent = {depth.width, depth.height};
} else {
const auto& limits = buffer.GetGraphics().GetPhysicalDeviceProperties().limits;
framebuffer_extent = {limits.maxFramebufferWidth, limits.maxFramebufferHeight};
} }
const auto final_scissor = calc_final_scissor(vp, ctx.GetScanModeControl(), framebuffer_extent); const auto final_scissor = calc_final_scissor(vp, ctx.GetScanModeControl(), framebuffer_extent);
@@ -648,8 +651,12 @@ RenderState RenderExecutor::AcquireRenderTargets(CommandBuffer& buffer, RenderCo
attachment.has_stencil = static_cast<bool>(aspects & vk::ImageAspectFlagBits::eStencil); attachment.has_stencil = static_cast<bool>(aspects & vk::ImageAspectFlagBits::eStencil);
attachment.stencil_clear = depth.stencil_clear_enable; attachment.stencil_clear = depth.stencil_clear_enable;
} }
if (attachment_samples == 0 || if (color_count == 0 && !depth.image_id) {
vulkan_sample_count(attachment_samples) == vk::SampleCountFlagBits {}) { const auto& limits = buffer.GetGraphics().GetPhysicalDeviceProperties().limits;
state.width = limits.maxFramebufferWidth;
state.height = limits.maxFramebufferHeight;
} else if (attachment_samples == 0 ||
vulkan_sample_count(attachment_samples) == vk::SampleCountFlagBits {}) {
EXIT("render state has no valid attachments\n"); EXIT("render state has no valid attachments\n");
} }
if (state.num_layers == std::numeric_limits<uint32_t>::max()) { if (state.num_layers == std::numeric_limits<uint32_t>::max()) {
@@ -941,14 +948,14 @@ bool RenderExecutor::PrepareDrawRenderState(uint64_t submit_id, RenderCommandBuf
} }
ResolveRenderDepthTarget(submit_id, buffer, state.depth_info); ResolveRenderDepthTarget(submit_id, buffer, state.depth_info);
state.ps_active = DrawHasActivePixelShader(buffer);
const bool with_depth = (state.depth_info.format != vk::Format::eUndefined && const bool with_depth = (state.depth_info.format != vk::Format::eUndefined &&
static_cast<bool>(state.depth_info.image_id)); static_cast<bool>(state.depth_info.image_id));
if (state.color_count == 0 && !with_depth) { if (state.color_count == 0 && !with_depth && !state.ps_active) {
LogFramebufferSkip(draw.name, state.color_info[0], state.depth_info, buffer, LogFramebufferSkip(draw.name, state.color_info[0], state.depth_info, buffer,
draw.index_count, draw.flags); draw.index_count, draw.flags);
return false; return false;
} }
state.ps_active = DrawHasActivePixelShader(buffer);
return true; return true;
} }