From d4bb7fd7868b62b23386cf4a7f464998ec749c64 Mon Sep 17 00:00:00 2001 From: nmzik Date: Sun, 11 Oct 2026 03:03:26 +0200 Subject: [PATCH] agc: remove command buffer debug dump --- src/libs/agc.cpp | 104 ----------------------------------------------- 1 file changed, 104 deletions(-) diff --git a/src/libs/agc.cpp b/src/libs/agc.cpp index c116706a8..cb207642a 100644 --- a/src/libs/agc.cpp +++ b/src/libs/agc.cpp @@ -259,29 +259,6 @@ struct CommandBuffer { void* user_data; uint32_t reserved_dw; - void DbgDump() const { - if (!Config::GraphicsDebugDumpEnabled() || - Config::GetPrintfDirection() == Config::LogDirection::Silent) { - return; - } - static std::atomic log_count {0}; - if (log_count.fetch_add(1) >= 64) { - return; - } - - LOGF("\t bottom = 0x%016" PRIx64 "\n" - "\t top = 0x%016" PRIx64 "\n" - "\t cursor_up = 0x%016" PRIx64 "\n" - "\t cursor_down = 0x%016" PRIx64 "\n" - "\t callback = 0x%016" PRIx64 "\n" - "\t user_data = 0x%016" PRIx64 "\n" - "\t reserved_dw = %" PRIu32 "\n", - reinterpret_cast(bottom), reinterpret_cast(top), - reinterpret_cast(cursor_up), reinterpret_cast(cursor_down), - reinterpret_cast(callback), reinterpret_cast(user_data), - reserved_dw); - } - [[nodiscard]] KYTY_SYSV_ABI uint64_t GetAvailableSizeDW() const { // Interpret the signed cursor distance as an unsigned 64-bit DWORD count. const auto distance = static_cast(reinterpret_cast(cursor_down) - @@ -302,7 +279,6 @@ struct CommandBuffer { "\t command buffer exhausted and has no grow callback: requested = %" PRIu32 ", remaining = %" PRIu64 ", reserved_dw = %" PRIu32 "\n", num_dw, remaining, reserved_dw); - DbgDump(); return false; } @@ -312,7 +288,6 @@ struct CommandBuffer { "\t command buffer grow callback failed: requested = %" PRIu32 ", remaining = %" PRIu64 ", reserved_dw = %" PRIu32 "\n", num_dw, remaining, reserved_dw); - DbgDump(); return false; } if (GetAvailableSizeDW() < num_dw) { @@ -321,7 +296,6 @@ struct CommandBuffer { "requested = %" PRIu32 ", remaining = %" PRIu64 ", reserved_dw = %" PRIu32 "\n", num_dw, GetAvailableSizeDW(), reserved_dw); - DbgDump(); return false; } } @@ -1598,8 +1572,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbContextStateOp(CommandBuffer* buf, uint32_t operat return nullptr; } - buf->DbgDump(); - uint32_t* first = nullptr; const auto append = [&](uint32_t segment_size_dw) { auto* segment = buf->AllocateDW(segment_size_dw); @@ -1902,8 +1874,6 @@ uint32_t* KYTY_SYSV_ABI AgcCbSetShRegisterRangeDirect(CommandBuffer* buf, uint32 EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(num_values + 2); if (cmd == nullptr) { @@ -1945,8 +1915,6 @@ uint32_t* KYTY_SYSV_ABI AgcCbSetShRegistersDirect(CommandBuffer* EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED(regs == nullptr); - buf->DbgDump(); - std::vector local_regs(num_regs); for (uint32_t i = 0; i < num_regs; i++) { local_regs[i].offset = regs[i].offset; @@ -2012,8 +1980,6 @@ uint32_t* KYTY_SYSV_ABI AgcCbSetUcRegistersDirect(CommandBuffer* EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED(regs == nullptr); - buf->DbgDump(); - // Original implementation stages register values in a temporary DWORD array. It reads each new run only // after the preceding run has been allocated, so preserve that ordering around grow callbacks. std::vector values(num_regs); @@ -2104,8 +2070,6 @@ uint32_t* KYTY_SYSV_ABI AgcCbReleaseMem(CommandBuffer* buf, uint8_t action, uint data_sel != 5); EXIT_NOT_IMPLEMENTED(interrupt > 4); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(8); if (cmd == nullptr) { @@ -2158,8 +2122,6 @@ uint32_t* KYTY_SYSV_ABI AgcAcbResetQueue(CommandBuffer* buf, uint32_t op) { EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED((op & ~0x1c2u) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(2); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2180,8 +2142,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbResetQueue(CommandBuffer* buf, uint32_t op, uint32 EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED((op & ~0xfffu) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(2); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2203,8 +2163,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbWaitUntilSafeForRendering(CommandBuffer* buf, EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(7); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2257,8 +2215,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetWorkloadsActive(CommandBuffer* buf, uint32_t st } } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(WORKLOAD_ACTIVE_PACKET_SIZE_DW); if (cmd == nullptr) { return nullptr; @@ -2294,8 +2250,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetWorkloadComplete(CommandBuffer* buf, uint32_t s } } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(WORKLOAD_COMPLETE_PACKET_SIZE_DW); if (cmd == nullptr) { return nullptr; @@ -2319,8 +2273,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetShRegisterDirect(CommandBuffer* buf, ShaderRegi EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); if (cmd == nullptr) { @@ -2340,8 +2292,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetCxRegisterDirect(CommandBuffer* buf, ShaderRegi EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); if (cmd == nullptr) { @@ -2367,8 +2317,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetUcRegisterDirect(CommandBuffer* buf, ShaderRegi EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); if (cmd == nullptr) { @@ -2394,8 +2342,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetCxRegistersIndirect(CommandBuffer* EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(RegIndirectPacketSizeDw); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2423,8 +2369,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetShRegistersIndirect(CommandBuffer* EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(RegIndirectPacketSizeDw); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2453,8 +2397,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetUcRegistersIndirect(CommandBuffer* EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(RegIndirectPacketSizeDw); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2475,8 +2417,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetIndexSize(CommandBuffer* buf, uint8_t index_siz index_size, cache_policy); EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2496,8 +2436,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetIndexBuffer(CommandBuffer* buf, uint64_t index_ EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED((index_addr & 1u) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2516,8 +2454,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetIndexCount(CommandBuffer* buf, uint32_t index_c EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(2); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2537,8 +2473,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetNumInstances(CommandBuffer* buf, uint32_t num_i return nullptr; } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(2); if (cmd == nullptr) { @@ -2635,8 +2569,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndex(CommandBuffer* buf, uint32_t index_count EXIT_NOT_IMPLEMENTED(index_addr == nullptr); EXIT_NOT_IMPLEMENTED((reinterpret_cast(index_addr) & 1u) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(6); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2678,8 +2610,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndexMultiInstanced(CommandBuffer* buf, uint32 EXIT_NOT_IMPLEMENTED(object_ids == nullptr); EXIT_NOT_IMPLEMENTED((reinterpret_cast(index_addr) & 1u) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(9); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2747,8 +2677,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndexAuto(CommandBuffer* buf, uint32_t index_c EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2777,8 +2705,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndexOffset(CommandBuffer* buf, uint32_t index EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(5); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2808,8 +2734,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetBaseIndirectArgs(CommandBuffer* buf, uint32_t s EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(4); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2834,8 +2758,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndexIndirect(CommandBuffer* buf, uint32_t dat EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(5); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2863,8 +2785,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndirect(CommandBuffer* buf, uint32_t data_off EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(5); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -2901,8 +2821,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndirectMulti(CommandBuffer* buf, return nullptr; } - buf->DbgDump(); - constexpr uint32_t draw_packet_size_dw = 10u; constexpr uint32_t total_size_dw = AGC_INTERNAL_DATA_PACKET_SIZE_DW + draw_packet_size_dw + @@ -2963,8 +2881,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDrawIndexIndirectMulti(CommandBuffer* buf, EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED((count_indirect & ~1u) != 0); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(10); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -3013,8 +2929,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbDispatchIndirect(CommandBuffer* buf, uint32_t data EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(3); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -3046,8 +2960,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbEventWrite(CommandBuffer* buf, uint8_t event_type, EXIT_NOT_IMPLEMENTED(buf == nullptr); EXIT_NOT_IMPLEMENTED(event_type > 0x3fu); - buf->DbgDump(); - const bool addressed_event = ((event_type & 0xfeu) == 0x38u); auto* cmd = buf->AllocateDW(addressed_event ? 4u : 2u); @@ -3143,8 +3055,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbAcquireMem(CommandBuffer* buf, uint8_t engine, uin } } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(8); if (cmd == nullptr) { @@ -3203,8 +3113,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbCondExec(CommandBuffer* buf, const volatile uint32 return nullptr; } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(5); if (cmd == nullptr) { @@ -3376,8 +3284,6 @@ uint32_t* KYTY_SYSV_ABI AgcAcbDispatchIndirect(CommandBuffer* buf, return nullptr; } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(4); if (cmd == nullptr) { @@ -3426,8 +3332,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbStallCommandBufferParser(CommandBuffer* buf) { EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(2); EXIT_NOT_IMPLEMENTED(cmd == nullptr); @@ -3847,8 +3751,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbWriteData(CommandBuffer* buf, uint8_t dst, uint8_t return nullptr; } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(4 + num_dwords); if (cmd == nullptr) { @@ -3901,8 +3803,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbGetLodStats(CommandBuffer* buf, uint8_t cache_poli return nullptr; } - buf->DbgDump(); - auto* cmd = buf->AllocateDW(5); if (cmd == nullptr) { @@ -4105,8 +4005,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbWaitRegMem(CommandBuffer* buf, uint8_t size, uint8 cache_policy); } - buf->DbgDump(); - auto address_value = reinterpret_cast(address); bool wait32 = (size == 0); auto poll = wait_reg_mem_poll_cycles_to_packet(poll_cycles); @@ -4236,8 +4134,6 @@ uint32_t* KYTY_SYSV_ABI AgcDcbSetFlip(CommandBuffer* buf, uint32_t video_out_han EXIT_NOT_IMPLEMENTED(buf == nullptr); - buf->DbgDump(); - auto* cmd = buf->AllocateDW(6); EXIT_NOT_IMPLEMENTED(cmd == nullptr);